feat(code_review): Validate before scheduling#108545
Open
feat(code_review): Validate before scheduling#108545
Conversation
Adds validation to schedule_task() to catch schema mismatches early, before tasks are scheduled to the task broker. This prevents task failures when model changes are deployed to task brokers before Sentry workers are updated. Changes: - Validate transformed event payload using Pydantic models before scheduling the Celery task - Use appropriate model (SeerCodeReviewTaskRequestForPrClosed or SeerCodeReviewTaskRequestForPrReview) based on request_type - Log validation failures with detailed context - Record INVALID_PAYLOAD metric when validation fails - Add tests to verify validation happens before task scheduling Fixes: CW-837 Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
Removes validation logic from process_github_webhook_event task since payload is now validated before scheduling in schedule_task(). This prevents double validation and ensures the validation happens at the right layer - before tasks are queued to the broker rather than during task execution. Changes: - Remove Pydantic validation from process_github_webhook_event - Move enum key conversion to schedule_task after validation - Update docstring to clarify payload is pre-validated - Simplify task execution to just forward payload to Seer Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Remove extra context from validation failure log statement to keep logging concise. Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
- Integrate tags parameter added in master - Keep pre-scheduling validation logic - Remove duplicate validation from task execution - Revert unrelated changes to pull_request.py and issue_comment.py Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
armenzg
commented
Feb 23, 2026
| ) | ||
| return | ||
|
|
||
| # Validate payload before scheduling to catch schema mismatches early |
Member
Author
There was a problem hiding this comment.
This validation is now happening within schedule_task before we schedule the task, thus, model changes and payload changes happen cannot be out of date.
Remove unused 'e' variable from exception handler to fix linting. Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Remove tests that expected validation errors during task execution, since validation now happens before scheduling. Validation at the scheduling layer is already covered by tests in test_pull_request.py. Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Address Bugbot concerns: 1. Catch only pydantic.ValidationError instead of all exceptions to avoid hiding unexpected failures 2. Add datetime serialization in convert_enum_keys_to_strings() to ensure Celery can serialize all payload values Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
orjson.dumps() in make_seer_request() already handles datetime serialization automatically. Converting datetime to strings early breaks tests that expect datetime objects in the payload. Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
suejungshin
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pre-scheduling validation for
event_payloadwithinschedule_taskto prevent invalid tasks from being queued.This addresses issues where model changes could lead to tasks being scheduled with incompatible payloads when task brokers are updated before Sentry workers, causing failures downstream. Validation now occurs before the Celery task is dispatched, catching schema mismatches early and improving system robustness.
Linear Issue: CW-837